Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-magic non-special projectiles become four times faster #10179

Merged
merged 4 commits into from Dec 23, 2018

Conversation

Projects
None yet
8 participants
@zamolxius
Copy link

commented Dec 21, 2018

[Changelogs]: testmerge if possible
馃啈 zamolxius
balance: rebalanced projectiles, except magic and special ones, to be four times faster
/馃啈

[why]: makes projectiles less trivial and may change the meta. testmerge if possible

@yoyobatty
Copy link

left a comment

I was going to make another pr that doubled shotgun pellets but halved damage

@uBadush

This comment has been minimized.

Copy link

commented Dec 21, 2018

+1

@yoyobatty

This comment has been minimized.

Copy link

commented Dec 21, 2018

This doesn't affect energy weapons at all which still travel at a speed of 0.7

@uBadush

This comment has been minimized.

Copy link

commented Dec 21, 2018

Then make energy weapons travel faster too

@zamolxius

This comment has been minimized.

Copy link
Author

commented Dec 21, 2018

ok lemme see

zamolxius added some commits Dec 21, 2018

@zamolxius

This comment has been minimized.

Copy link
Author

commented Dec 21, 2018

@bardofrage

This comment has been minimized.

Copy link

commented Dec 22, 2018

+1, no reason to currently use a gun over a taser.

@t-f-w

This comment has been minimized.

Copy link

commented Dec 22, 2018

+1

@Manly-Dwarf

This comment has been minimized.

Copy link

commented Dec 22, 2018

Does this speed up tasers and disablers?
If so, the headmins just +1'd this and we're all doomed. I hate you.

@t-f-w

This comment has been minimized.

Copy link

commented Dec 22, 2018

:agony:

@yoyobatty

This comment has been minimized.

Copy link

commented Dec 22, 2018

Indeed it does.

/obj/item/projectile/beam
speed = 0.2

/obj/item/projectile/bullet/p50

This comment has been minimized.

Copy link
@Manly-Dwarf

This comment has been minimized.

Copy link
@yoyobatty

yoyobatty Dec 22, 2018

For disablers, pulse rifles, lethal eguns

This comment has been minimized.

Copy link
@Manly-Dwarf

Manly-Dwarf Dec 22, 2018

ABORT
Also what this was set to was p50, was wondering why it was here

This comment has been minimized.

Copy link
@zamolxius

zamolxius Dec 22, 2018

Author

p50 is the sniper rifle bullet iirc

/obj/item/projectile
speed = 0.2 //four times faster

/obj/item/projectile/magic

This comment has been minimized.

Copy link
@Manly-Dwarf

Manly-Dwarf Dec 22, 2018

If you're going to be specific with p90, why not be specific with fireball & MM?

This comment has been minimized.

Copy link
@yoyobatty

yoyobatty Dec 22, 2018

P50 is actually a custom speed of 0.4, I codechecked.

This comment has been minimized.

Copy link
@zamolxius

zamolxius Dec 22, 2018

Author

magic isnt propulsed by the holy power of bullet propellants and the Omnissiah

@t-f-w

This comment has been minimized.

Copy link

commented Dec 22, 2018

don鈥檛 speed those up you FOOL

@yoyobatty
Copy link

left a comment

Please ammend changes

@bardofrage

This comment has been minimized.

Copy link

commented Dec 22, 2018

Gonna have to retract my -1, unless the taser remains at normal speed.

@zamolxius

This comment has been minimized.

Copy link
Author

commented Dec 22, 2018

how about taser just a mite faster?

/obj/item/projectile/energy/electrode
speed = 0.8

/obj/item/projectile/beam

This comment has been minimized.

Copy link
@GuyonBroadway

GuyonBroadway Dec 22, 2018

this has been redefined in another file, this means we will have a redefine of a redefine which is probably bad.

This comment has been minimized.

Copy link
@yoyobatty

yoyobatty Dec 22, 2018

Yes, please test every single one of these in VV. You can check by spawning ammo_casing and then checking the reference to the projectile.

This comment has been minimized.

Copy link
@zamolxius

zamolxius Dec 22, 2018

Author

disabler was redefined as 0.7 but i deleted that

@yoyobatty
Copy link

left a comment

Okay, looks fine has enough +1's and followed requested changes, going to merge.

@yoyobatty yoyobatty merged commit 8ea3fd6 into HippieStation:master Dec 23, 2018

1 of 3 checks passed

Diffs - Pull Request #10179 No Modified Icons
Details
Map Diff Renders - Pull Request #10179 No Modified Maps
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zamolxius zamolxius deleted the zamolxius:projectile_speed branch Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.