New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mhacontrol resets calibration #4

Closed
m-r-s opened this Issue Dec 4, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@m-r-s
Copy link

m-r-s commented Dec 4, 2017

When connecting to openMHA with the Octave-based GUI (mhacontrol.m) the calibration provided in the configuration file is overwritten with default values.
This is unexpected behavior.

As a result openMHA can only be calibrated xor fitted but not calibrated and fitted.

@suaefar

This comment has been minimized.

Copy link

suaefar commented Dec 5, 2017

I implemented a temporary "fix" #5

@tobiasherzke

This comment has been minimized.

Copy link
Collaborator

tobiasherzke commented Dec 6, 2017

I confirm the observed behaviour.

The reason why it behaves like this, is separation of configuration and calibration, see below. But as you are now the second openMHA user running into this problem, I think we should address this issue sooner than planned, i.e. before we release a generic calibration tool.

Ultimately, calibration is done using the configuration variables (of plugin transducers). But suppose you have multiple identical setups, performing the same signal processing, and which are connected to identical sound hardware. The production spread of the sound hardware will require different calibration values for each instance.

The idea to solve this is to have a calibration tool inside mhacontrol which can walk the user through the necessary measurement steps to calibrate their system, and then save the calibration data on the system where mhacontrol is executing.

The next time mhacontrol starts connected to the same system, it would reupload the latest calibration data.

The calibration tool that we have right now is not generic enough to calibrate arbitrary sound hardware. This will be addressed by the calibration tool to be developed next year.

Our fix for now should be to not modify the values in the transducers plugin if we have never stored calibration values for that system.

@suaefar

This comment has been minimized.

Copy link

suaefar commented Dec 6, 2017

That sounds like an intuitive solution to me.

@hendrikkayser

This comment has been minimized.

Copy link
Collaborator

hendrikkayser commented Feb 13, 2018

Was fixed by release 4.5.4.

@hendrikkayser

This comment has been minimized.

Copy link
Collaborator

hendrikkayser commented Feb 14, 2018

There was a glitch in yesterday's release 4.5.4. This issue will be fixed very soon.

@hendrikkayser hendrikkayser reopened this Feb 14, 2018

@hendrikkayser

This comment has been minimized.

Copy link
Collaborator

hendrikkayser commented Feb 14, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment