feat(api)!: add distinct error type #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 21, 2021 03:30
The commit adds an `Error` enum to the public API of the opml crate to make it easier to reason about what went wrong during OPML parsing/writing.
This change required a PR to get merged upstream for the strong-xml crate.
Bauke
approved these changes
Mar 22, 2021
|
Thanks for merging this quickly and pushing a new version to crates :) Now I can finish my podcast manager 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds an
Errorenum to the public API of the opml crate tomake it easier to reason about what went wrong during OPML
parsing/writing.