diff --git a/.github/workflows/clazy.yml b/.github/workflows/clazy.yml index 026bf170427..8a59be3fae5 100644 --- a/.github/workflows/clazy.yml +++ b/.github/workflows/clazy.yml @@ -8,18 +8,24 @@ jobs: clazy: runs-on: ubuntu-20.04 steps: - - uses: actions/checkout@v2 + - name: Check out repository + uses: actions/checkout@v2 - name: Install build dependencies run: sudo apt-get update && sudo apt-get install -y --no-install-recommends libavformat-dev libchromaprint-dev libebur128-dev libfftw3-dev libflac-dev libid3tag0-dev liblilv-dev libmad0-dev libmodplug-dev libmp3lame-dev libopus-dev libopusfile-dev libportmidi-dev libprotobuf-dev libqt5opengl5-dev libqt5sql5-sqlite libqt5svg5-dev libqt5x11extras5-dev librubberband-dev libshout3-dev libsndfile1-dev libsoundtouch-dev libsqlite3-dev libtag1-dev libupower-glib-dev libusb-1.0-0-dev libwavpack-dev portaudio19-dev protobuf-compiler qt5-default qtscript5-dev qt5keychain-dev clazy cmake - - name: Build - run: | - mkdir cmake_build - cd cmake_build - # Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 - cmake -DCMAKE_BUILD_TYPE=Debug -DWARNINGS_FATAL=ON -DOPTIMIZE=off -DBATTERY=ON -DBROADCAST=ON -DBULK=ON -DHID=ON -DLILV=ON -DOPUS=ON -DQTKEYCHAIN=ON -DVINYLCONTROL=ON -DFFMPEG=ON -DKEYFINDER=ON -DLOCALECOMPARE=ON -DMAD=ON -DMODPLUG=ON -DWAVPACK=ON .. - cmake --build . -j $(nproc) + - name: Create Build direcotry + run: mkdir cmake_build + - name: Configure + # Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 + run: cmake -DCMAKE_BUILD_TYPE=Debug -DWARNINGS_FATAL=ON -DOPTIMIZE=off -DBATTERY=ON -DBROADCAST=ON -DBULK=ON -DHID=ON -DLILV=ON -DOPUS=ON -DQTKEYCHAIN=ON -DVINYLCONTROL=ON -DFFMPEG=ON -DKEYFINDER=ON -DLOCALECOMPARE=ON -DMAD=ON -DMODPLUG=ON -DWAVPACK=ON .. + working-directory: cmake_build env: LD: clang++ CC: clang CXX: clazy + - name: Set up problem matcher + uses: ammaraskar/gcc-problem-matcher@master + - name: Build + run: cmake --build . -j $(nproc) + working-directory: cmake_build + env: CLAZY_CHECKS: level1,no-rule-of-two-soft,no-non-pod-global-static,no-qproperty-without-notify,no-wrong-qevent-cast diff --git a/src/engine/sync/enginesync.cpp b/src/engine/sync/enginesync.cpp index 62a7555abc6..8d2cd4c2ae8 100644 --- a/src/engine/sync/enginesync.cpp +++ b/src/engine/sync/enginesync.cpp @@ -477,7 +477,7 @@ Syncable* EngineSync::pickNonSyncSyncTarget(EngineChannel* pDontPick) const { bool EngineSync::otherSyncedPlaying(const QString& group) { bool othersInSync = false; - for (Syncable* theSyncable : qAsConst(m_syncables)) { + for (Syncable* theSyncable : m_syncables) { bool isSynchonized = theSyncable->isSynchronized(); if (theSyncable->getGroup() == group) { if (!isSynchonized) { diff --git a/src/track/serato/markers2.cpp b/src/track/serato/markers2.cpp index a7a192f3c10..31afdb571ab 100644 --- a/src/track/serato/markers2.cpp +++ b/src/track/serato/markers2.cpp @@ -567,7 +567,7 @@ QByteArray SeratoMarkers2::dumpID3() const { QList SeratoMarkers2::findEntriesByType( SeratoMarkers2Entry::TypeId typeId) const { QList entriesFound; - for (const auto& pEntry : qAsConst(m_entries)) { + for (const auto& pEntry : m_entries) { VERIFY_OR_DEBUG_ASSERT(pEntry) { continue; }