Repository navigation
workflows: fix artipacked zizmor findings - #630
Merged
Merged
Conversation
Member
Specifically anything that interacts with a remote (e.g. git push). A while back I actually got ahead of the game here and by making most workflows in this repo work without any tokens:
So if I did it correctly, you shouldn't need credentials for anything here anymore. |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
p-linnane
force-pushed
the
fix-zizmor-findings
branch
from
December 15, 2024 07:00
6286eff to
2a89df7
Compare
Bo98
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying again to fix these. I set
persist-credentials: truefor any jobs that had git operations, andfalsefor the others. Let me know if I misunderstood.