Skip to content

workflows: fix artipacked zizmor findings - #630

Merged
p-linnane merged 1 commit into
masterfrom
fix-zizmor-findings
Dec 15, 2024
Merged

p-linnane merged 1 commit into
masterfrom
fix-zizmor-findings

Conversation

@p-linnane

Copy link
Copy Markdown
Contributor

Trying again to fix these. I set persist-credentials: true for any jobs that had git operations, and false for the others. Let me know if I misunderstood.

@p-linnane
p-linnane requested a review from Bo98 December 15, 2024 06:43
@Bo98

Bo98 commented Dec 15, 2024 •

Copy link
Copy Markdown
Member

Trying again to fix these. I set persist-credentials: true for any jobs that had git operations, and false for the others. Let me know if I misunderstood.

Specifically anything that interacts with a remote (e.g. git push).

A while back I actually got ahead of the game here and by making most workflows in this repo work without any tokens:

  • git-user-config just sets a config - no pushing
  • setup-commit-signing similar
  • git-try-push actually sets up a file:// remote to push now (it previously did just push to GitHub)

So if I did it correctly, you shouldn't need credentials for anything here anymore.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane
p-linnane merged commit a2e1c63 into master Dec 15, 2024
@p-linnane
p-linnane deleted the fix-zizmor-findings branch December 15, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants