Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew 2.0.0 #319

Merged
merged 6 commits into from Feb 2, 2019

Conversation

Projects
None yet
5 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 31, 2019

The release notes for Homebrew 2.0.0.

@claui

claui approved these changes Jan 31, 2019

Copy link
Member

claui left a comment

👍 as-is.

From a non-native speaker’s point of view, I’ve made a few suggestions to make the text easier to read and to get rid of a few details that may not be important for most users.

Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
@scpeters
Copy link
Contributor

scpeters left a comment

that's a really impressive list of accomplishments; good job everyone!

Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
@MikeMcQuaid

This comment has been minimized.

Copy link
Member Author

MikeMcQuaid commented Jan 31, 2019

@scpeters @claui Thanks for review and fixes 😍

claui and others added some commits Jan 31, 2019

Update _posts/2019-02-02-homebrew-2.0.0.md
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>
Update _posts/2019-02-02-homebrew-2.0.0.md
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:2.0.0 branch from 11279aa to 19248a5 Jan 31, 2019

@sjackman
Copy link
Member

sjackman left a comment

Looks good! A few wording comments. Take what you like.

Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated
Show resolved Hide resolved _posts/2019-02-02-homebrew-2.0.0.md Outdated

sjackman and others added some commits Feb 1, 2019

Update _posts/2019-02-02-homebrew-2.0.0.md
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:2.0.0 branch from 2bca686 to 4ead89f Feb 1, 2019

@claui

claui approved these changes Feb 1, 2019

@@ -5,12 +5,12 @@ en:
question: What Does Homebrew Do?
what: Homebrew installs <a href="https://formulae.brew.sh/formula/" title="List of Homebrew packages">the stuff you need</a> that Apple (or your Linux system) didn’t.
how: Homebrew installs packages to their own directory and then symlinks their files into <code>/usr/local</code>.
prefix: Homebrew won’t install files outside its prefix, and you can place a Homebrew installation wherever you like.
prefix: Homebrew won’t install files outside its prefix and you can place a Homebrew installation wherever you like.

This comment has been minimized.

@sjackman

sjackman Feb 1, 2019

Member

Reject Oxford commas.

😆

This particular comma is not an oxford comma. The phrases to the left and right of the comma are both complete sentences. You could replace the and with a period (full stop). In that case, the comma is required, since it's separating two independent clauses joined by a coordinating conjunction.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Feb 1, 2019

Author Member

It may not be an Oxford comma but it does seem superfluous and inconsistent with the extra above.

COMMA WARS

This comment has been minimized.

@sjackman

sjackman Feb 1, 2019

Member

OH IT'S ON!

This comment has been minimized.

@sjackman

sjackman Feb 1, 2019

Member

If you're short on commas, Mike, I can lend you a few, for the weekend. 😛

@sjackman
Copy link
Member

sjackman left a comment

Fix one comma.

createpackages: Trivially create your own Homebrew packages.
hack: It's all Git and Ruby underneath, so hack away with the knowledge that you can easily revert your modifications and merge upstream updates.
formula: "Homebrew formulae are simple Ruby scripts:"
editor: opens in $EDITOR!
complement: Homebrew complements macOS (or your Linux system). Install your RubyGems with <code>gem</code>, and their dependencies with <code>brew</code>.
complement: Homebrew complements macOS (or your Linux system). Install your RubyGems with <code>gem</code> and their dependencies with <code>brew</code>.

This comment has been minimized.

@javian

javian Feb 1, 2019

Member

Are we not diminishing Linux by putting it in parentheses ?

This comment has been minimized.

@sjackman

sjackman Feb 1, 2019

Member

This comma was in the wrong place. It should be moved to line 8. I'm glad that you were able to find a spare comma, one that you are now able to employ elsewhere. I didn't really want to lend you any of my commas. I'm attached to them. They have sentimental value.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Feb 2, 2019

Author Member

@javian yes, we are a bit but that’s because it’s implying WSL too and Homebrew will always be a primarily macOS package manager. It also implies the “missing” is for macOS but not for Linux.

@MikeMcQuaid MikeMcQuaid merged commit a6f145d into Homebrew:master Feb 2, 2019

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:2.0.0 branch Feb 2, 2019

@claui

This comment has been minimized.

Copy link
Member

claui commented Feb 2, 2019

IT’S HAPPENING 🎉

@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Feb 2, 2019

🎆 🍾 🥂

@lock lock bot added the outdated label Mar 4, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Mar 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.