New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew 2.0.0 #319
Homebrew 2.0.0 #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as-is.
From a non-native speaker’s point of view, I’ve made a few suggestions to make the text easier to read and to get rid of a few details that may not be important for most users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a really impressive list of accomplishments; good job everyone!
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few wording comments. Take what you like.
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com>
@@ -5,12 +5,12 @@ en: | |||
question: What Does Homebrew Do? | |||
what: Homebrew installs <a href="https://formulae.brew.sh/formula/" title="List of Homebrew packages">the stuff you need</a> that Apple (or your Linux system) didn’t. | |||
how: Homebrew installs packages to their own directory and then symlinks their files into <code>/usr/local</code>. | |||
prefix: Homebrew won’t install files outside its prefix, and you can place a Homebrew installation wherever you like. | |||
prefix: Homebrew won’t install files outside its prefix and you can place a Homebrew installation wherever you like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject Oxford commas.
😆
This particular comma is not an oxford comma. The phrases to the left and right of the comma are both complete sentences. You could replace the and
with a period (full stop). In that case, the comma is required, since it's separating two independent clauses joined by a coordinating conjunction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not be an Oxford comma but it does seem superfluous and inconsistent with the extra above.
COMMA WARS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH IT'S ON!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're short on commas, Mike, I can lend you a few, for the weekend. 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix one comma.
createpackages: Trivially create your own Homebrew packages. | ||
hack: It's all Git and Ruby underneath, so hack away with the knowledge that you can easily revert your modifications and merge upstream updates. | ||
formula: "Homebrew formulae are simple Ruby scripts:" | ||
editor: opens in $EDITOR! | ||
complement: Homebrew complements macOS (or your Linux system). Install your RubyGems with <code>gem</code>, and their dependencies with <code>brew</code>. | ||
complement: Homebrew complements macOS (or your Linux system). Install your RubyGems with <code>gem</code> and their dependencies with <code>brew</code>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not diminishing Linux by putting it in parentheses ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comma was in the wrong place. It should be moved to line 8. I'm glad that you were able to find a spare comma, one that you are now able to employ elsewhere. I didn't really want to lend you any of my commas. I'm attached to them. They have sentimental value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javian yes, we are a bit but that’s because it’s implying WSL too and Homebrew will always be a primarily macOS package manager. It also implies the “missing” is for macOS but not for Linux.
IT’S HAPPENING 🎉 |
🎆 🍾 🥂 |
The release notes for Homebrew 2.0.0.