Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Lint blog posts with Vale #446

Merged
merged 1 commit into from Jan 6, 2020
Merged

CI: Lint blog posts with Vale #446

merged 1 commit into from Jan 6, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 6, 2020

  • Requested in Homebrew/brew#6826 (comment).
  • Using the styles in Homebrew/brew, run Vale docs linting on blog posts here.
  • I went for the easy approach by using a macOS runner for this as it already has Homebrew installed.
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 6, 2020

Would ideally like to avoid this being two runners if there's a non-terrible way of installing on macOS? Alternatively could run all tests on macOS.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 6, 2020

installing on macOS

installing on Linux, sorry!

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Looking at the Homebrew/brew prior art for running on Linux, it's just a copy-paste job but it still feels like more effort than this one line check probably deserves?

I'm happy to switch all of these to macOS.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 6, 2020

Looking at the Homebrew/brew prior art for running on Linux, it's just a copy-paste job but it still feels like more effort than this one line check probably deserves?

Is it available in a non-Homebrew package manager so we can install it that way?

Another option would be to use the Homebrew/brew Docker image?

If neither of the above is possible: I have no strong opinions about macOS vs. the above copy-paste job.

- Requested in https://github.com/Homebrew/brew /pull/6826#issuecomment-564450052.
- Using the styles in Homebrew/brew, run Vale docs linting on blog posts here.
- This uses the Homebrew/brew (Linux) Docker image to run the Vale
  linting checks in a separate job.
@issyl0 issyl0 force-pushed the issyl0:vale branch from bdf5cd5 to 1e20a7f Jan 6, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

Is it available in a non-Homebrew package manager so we can install it that way?

It is. But we need to reference the config and styles from Homebrew/brew so we need that repo anyway.

Another option would be to use the Homebrew/brew Docker image?

I've done this.

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 6, 2020

✔ 0 errors, 0 warnings and 0 suggestions in 15 files.

🎉

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jan 6, 2020

Great work, thanks again @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 875177e into Homebrew:master Jan 6, 2020
2 checks passed
2 checks passed
tests tests
Details
vale
Details
@issyl0 issyl0 deleted the issyl0:vale branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.