Skip to content

Commit

Permalink
diagnostic: limit fatal dev tools check to Sierra
Browse files Browse the repository at this point in the history
  • Loading branch information
DomT4 committed Sep 23, 2016
1 parent bbc3f1c commit 12aad5c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Library/Homebrew/extend/os/mac/diagnostic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ def development_tools_checks
end

def fatal_development_tools_checks
if ENV["TRAVIS"] || ARGV.homebrew_developer?
if MacOS.version >= :sierra && ENV["CI"].nil?
%w[
check_xcode_up_to_date
check_clt_up_to_date
]
else
%w[
check_xcode_up_to_date
check_clt_up_to_date
]
end
end
Expand Down

7 comments on commit 12aad5c

@stouset
Copy link

@stouset stouset commented on 12aad5c Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does Xcode need to be up-to-date if we have the latest version of the CLT?

@stouset
Copy link

@stouset stouset commented on 12aad5c Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to script a system-wide version of homebrew, and we can't necessarily rely on everyone having updated their version of Xcode. We can, however, ensure the latest CLT are installed via softwareupdate.

@jawshooah
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't necessarily rely on everyone having updated their version of Xcode

Couldn't you use mas to script that as well?

@stouset
Copy link

@stouset stouset commented on 12aad5c Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require us having a functional homebrew. Chicken, egg.

@stouset
Copy link

@stouset stouset commented on 12aad5c Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, some developers may wish to stay on older version of Xcode for whatever reason.

@jawshooah
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would require us having a functional homebrew

Not necessarily, they provide binaries through GitHub Releases as well.

Also, some developers may wish to stay on older version of Xcode for whatever reason.

Not much to be done about that. If you want to know more about the Xcode requirement, I'd suggest checking out #972 and the various issues that link to it.

@MikeMcQuaid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, some developers may wish to stay on older version of Xcode for whatever reason.

This is unsupported as it breaks many packages. We only make drastic failure like this when they are the hard-to-debug cause of many, many build issues. You need to either delete Xcode or update it to the latest version.

Couldn't you use mas to script that as well?

You could install/download a mas binary without Homebrew itself being installed.

Please sign in to comment.