Skip to content
Permalink
Browse files

diagnostic: limit fatal dev tools check to Sierra

  • Loading branch information...
DomT4 committed Sep 23, 2016
1 parent bbc3f1c commit 12aad5c65fee39c5f044e39ca1efcbed58aebd39
Showing with 3 additions and 3 deletions.
  1. +3 −3 Library/Homebrew/extend/os/mac/diagnostic.rb
@@ -14,13 +14,13 @@ def development_tools_checks
end

def fatal_development_tools_checks
if ENV["TRAVIS"] || ARGV.homebrew_developer?
if MacOS.version >= :sierra && ENV["CI"].nil?
%w[
check_xcode_up_to_date
check_clt_up_to_date
]
else
%w[
check_xcode_up_to_date
check_clt_up_to_date
]
end
end

7 comments on commit 12aad5c

@stouset

This comment has been minimized.

Copy link

stouset replied Oct 5, 2016

Why does Xcode need to be up-to-date if we have the latest version of the CLT?

@stouset

This comment has been minimized.

Copy link

stouset replied Oct 5, 2016

We're trying to script a system-wide version of homebrew, and we can't necessarily rely on everyone having updated their version of Xcode. We can, however, ensure the latest CLT are installed via softwareupdate.

@jawshooah

This comment has been minimized.

Copy link
Contributor

jawshooah replied Oct 6, 2016

we can't necessarily rely on everyone having updated their version of Xcode

Couldn't you use mas to script that as well?

@stouset

This comment has been minimized.

Copy link

stouset replied Oct 6, 2016

That would require us having a functional homebrew. Chicken, egg.

@stouset

This comment has been minimized.

Copy link

stouset replied Oct 6, 2016

Also, some developers may wish to stay on older version of Xcode for whatever reason.

@jawshooah

This comment has been minimized.

Copy link
Contributor

jawshooah replied Oct 6, 2016

That would require us having a functional homebrew

Not necessarily, they provide binaries through GitHub Releases as well.

Also, some developers may wish to stay on older version of Xcode for whatever reason.

Not much to be done about that. If you want to know more about the Xcode requirement, I'd suggest checking out #972 and the various issues that link to it.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid replied Oct 6, 2016

Also, some developers may wish to stay on older version of Xcode for whatever reason.

This is unsupported as it breaks many packages. We only make drastic failure like this when they are the hard-to-debug cause of many, many build issues. You need to either delete Xcode or update it to the latest version.

Couldn't you use mas to script that as well?

You could install/download a mas binary without Homebrew itself being installed.

Please sign in to comment.
You can’t perform that action at this time.