From b99a4bdb8d3e0125ea083afa7e7fa2a969988328 Mon Sep 17 00:00:00 2001 From: EricFromCanada Date: Thu, 21 Oct 2021 20:51:00 -0400 Subject: [PATCH] svn: work around certificate errors on macOS pre-10.15 --- Library/Homebrew/download_strategy.rb | 4 +++- Library/Homebrew/utils/svn.rb | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index f2c34437d96746..dc9a4a2ce3dd16 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -763,7 +763,9 @@ def fetch_repo(target, url, revision = nil, ignore_externals: false, timeout: ni args << "--ignore-externals" if ignore_externals - if meta[:trust_cert] == true + svn_version = Version.create(Utils::Svn.version) + if meta[:trust_cert] == true || svn_version <= Version.create("1.10") + args << "--trust-server-cert-failures=expired,not-yet-valid" if svn_version >= Version.create("1.9") args << "--trust-server-cert" args << "--non-interactive" end diff --git a/Library/Homebrew/utils/svn.rb b/Library/Homebrew/utils/svn.rb index 4c57e04832e09b..d699fecb639388 100644 --- a/Library/Homebrew/utils/svn.rb +++ b/Library/Homebrew/utils/svn.rb @@ -32,7 +32,8 @@ def remote_exists?(url) # OK to unconditionally trust here because we're just checking if a URL exists. system_command("svn", args: ["ls", url, "--depth", "empty", - "--non-interactive", "--trust-server-cert"], print_stderr: false).success? + "--trust-server-cert-failures=expired,not-yet-valid", + "--trust-server-cert", "--non-interactive"], print_stderr: false).success? end def clear_version_cache