diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 216b443b0be9b..3a800ba50d43d 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -8,6 +8,19 @@ FormulaAudit: FormulaAuditStrict: Enabled: true +# enable all pending rubocops +AllCops: + NewCops: enable + +# don't allow cops to be disabled in formulae +Style/DisableCopsWithinSourceCodeDirective: + Enabled: true + Exclude: + # TODO: really long lines but hard to resolve (but would be nice to do). + - '**/Formula/libgraphqlparser.rb' + # TODO: false positive in RuboCop, see if it can be worked around/fixed. + - '**/Formula/rpm.rb' + # make our hashes consistent Layout/HashAlignment: EnforcedHashRocketStyle: table @@ -46,12 +59,6 @@ Lint/AmbiguousRegexpLiteral: Lint/ParenthesesAsGroupedExpression: Enabled: false -# not enabled by default but nice to have -Lint/RaiseException: - Enabled: true -Lint/StructNewOverride: - Enabled: true - # most metrics don't make sense to apply for formulae/taps Metrics/AbcSize: Enabled: false diff --git a/Library/.rubocop_rspec.yml b/Library/.rubocop_rspec.yml index 6699a39d4f664..e855cce1cc555 100644 --- a/Library/.rubocop_rspec.yml +++ b/Library/.rubocop_rspec.yml @@ -8,6 +8,10 @@ AllCops: Exclude: - '**/vendor/**/*' +# allow style to be disabled in non-formulae code +Style/DisableCopsWithinSourceCodeDirective: + Enabled: false + # Intentionally disabled as it doesn't fit with our code style. RSpec/AnyInstance: Enabled: false