Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `brew bump-formula-pr` behave more usefully on Homebrew on Linux #6341

Open
issyl0 opened this issue Aug 1, 2019 · 9 comments

Comments

@issyl0
Copy link
Member

commented Aug 1, 2019

A detailed description of the proposed feature


For Homebrew formulae, there's a command that encourages users to contribute version bumps for formulae they use: brew bump-formula-pr.

This works great in Homebrew/homebrew-core for macOS, but not so great in Homebrew/linuxbrew-core as the version bump mechanism for the majority of Homebrew on Linux formulae is via merges from the macOS repo into the Linux repo, roughly once per day, done by maintainers.

Currently, Homebrew on Linux users who employ brew bump-formula-pr as their tool of choice raise their formulae PRs against Homebrew/linuxbrew-core as that's the default tap on Linux. This is a bad user experience, as users who try to be helpful end up with their pull-request closed by maintainers, because they've unknowingly submitted it to the wrong repo.

If the tap's remote is Homebrew/linuxbrew-core, brew bump-formula-pr could somehow:

  • Check that the formula that a user is trying to update exists in Homebrew/homebrew-core, then either:​
    • Raise the version bump PR against Homebrew/homebrew-core instead of Homebrew/linuxbrew-core
    • Signpost users towards Homebrew/homebrew-core with some text explaining why
    • Some other solution - feedback and ideas welcome!

The motivation for the feature

Currently, users who submit formulae updates are redirected by maintainers to submit their changes to Homebrew/homebrew-core in most cases, or they realise that themselves. This takes up maintainers' time. It's also potentially discouraging for the submitter, because their PR is closed through no fault of their own.

The tools that we advertise as being good entry points for contributing should work according to our workflows, across both macOS and Linux.

Evidence:

How the feature would be relevant to at least 90% of Homebrew users


A lot of users update formulae with brew bump-formula-pr in Homebrew/homebrew-core, and as Homebrew on Linux gains more users, we'll run into this problem more and more.

What alternatives to the feature have been considered

  • Maintainers signposting users manually, as we have been doing. But that takes up time that could be used elsewhere.
  • Not allowing users to brew bump-formula-pr while running Homebrew on Linux. This has the side effect of discouraging initial contributions from users, decreasing the likelihood that they will get more involved in the future.
@close-issue-app

This comment has been minimized.

Copy link

commented Aug 1, 2019

Whoops, it looks like you created an issue without filling out the checklist and providing all the needed information from one of the issue templates: https://github.com/Homebrew/brew/issues/new/choose

As we need all this information to help you we're closing this issue. If you add the necessary information to this issue (don't create a new or duplicate issue, please) and comment to let us know, a Homebrew maintainer will check it out when they get the chance. If it's deemed to be a valid issue then this issue may be reopened.

Sorry!

@close-issue-app close-issue-app bot closed this Aug 1, 2019
@jonchang jonchang reopened this Aug 1, 2019
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

This makes sense to me. Good idea @issyl0!

  • Not allowing users to brew bump-formula-pr while running Homebrew on Linux. This has the side effect of discouraging initial contributions from users, decreasing the likelihood that they will get more involved in the future.

This may make sense to do as a quick PR while the other one is in development.

@issyl0

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

[Not allowing users to brew bump-formula-pr while running Linux] may make sense to do as a quick PR while the other one is in development.

I was going to do a quick odie "Unsupported on Linux." unless OS.mac? edit to address this, then I remembered that brew bump-formula-pr is used for Linux-specific taps other than linuxbrew-core (for example linuxbrew/extra and xorg), and that would disable it for everyone no matter what formula they were trying to update in which tap. Due to this, I feel we should just wait for the actual improvements rather than dealing with these edge cases temporarily. 🤞 🙏

@issyl0 issyl0 referenced this issue Aug 13, 2019
@dawidd6

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

I just run into this issue. Good it is already tracked.

Can I ask if there are any ideas on how to make bump-formula-pr work on linux too?

@jonchang

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Can I ask if there are any ideas on how to make bump-formula-pr work on linux too?

Yes, this is under the header "A detailed description of the proposed feature" in the original post. Please feel free to open a pull request working on this; I'd be happy to review it.

@morganrconnolly

This comment has been minimized.

Copy link

commented Sep 5, 2019

I'd like to tackle this

@reitermarkus

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@morganrconnolly, please go ahead! 👍

@dawidd6

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

@morganrconnolly any progress on this?

@morganrconnolly

This comment has been minimized.

Copy link

commented Oct 5, 2019

@dawidd6 apologies for the delay. Here's a first stab #6538 . I'm not sure what the appropriate development workflow is for brew commands, e.g. how do modify a command, rebuild brew and then test the modified command. Is there any documentation about this you can point me towards?

@issyl0 issyl0 referenced this issue Oct 12, 2019
0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.