homebrew_bootsnap: fail more gracefully. #10538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 5, 2021
If `bootsnap` isn't available then print out an error message rather than failing all of Homebrew.
MikeMcQuaid
force-pushed
the
bootsnap_graceful_failure
branch
from
a8966b6
to
cdbc1d4
Compare
carlocab
approved these changes
Feb 5, 2021
There was a problem hiding this comment.
Seems to work:
❯ brew help
Error: HOMEBREW_BOOTSNAP could not `require "bootsnap"`!
Example usage:
brew search [TEXT|/REGEX/]
brew info [FORMULA...]
brew install FORMULA...
brew update
brew upgrade [FORMULA...]
brew uninstall FORMULA...
brew list [FORMULA...]
I had to break homebrew_bootsnap.rb to get it to produce an error, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
bootsnapisn't available then print out an error message rather than failing all of Homebrew.