Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "shims/mac/super: add ruby shims to set SDKROOT"" #10765

Merged
merged 2 commits into from Mar 4, 2021
Merged

Revert "Revert "shims/mac/super: add ruby shims to set SDKROOT"" #10765

merged 2 commits into from Mar 4, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 2, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Requires #10764.

@BrewTestBot
Copy link
Member

Review period will end on 2021-03-03 at 17:08:33 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 2, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 2, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@Bo98 Bo98 merged commit b8448c4 into Homebrew:master Mar 4, 2021
@Bo98 Bo98 deleted the ruby-shims branch March 4, 2021 16:37
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Apr 4, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @BrewTestBot @MikeMcQuaid @dawidd6