New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update.sh: always use stable branch for tags. #1121

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Sep 24, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This avoids creating a new branch that’ll never be deleted for each tag and differentiates between the master and stable branches.

update.sh: always use stable branch for tags.
This avoids creating a new branch that’ll never be deleted for each tag
and differentiates between the `master` and `stable` branches.
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Sep 24, 2016

@zmwangx Thoughts?

@zmwangx
Copy link
Contributor

zmwangx left a comment

👍 I believe this is more clear.

@MikeMcQuaid MikeMcQuaid merged commit 2f82837 into Homebrew:master Sep 24, 2016

4 checks passed

codecov/patch Coverage not affected.
Details
codecov/project 63.81% (+0.00%) compared to 0ba19c8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:update-stable-branch branch Sep 24, 2016

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.