New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further terminology in docs + link on README #1281

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
3 participants
@mbbroberg
Copy link
Contributor

mbbroberg commented Oct 13, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Addressing a few spots where I looked for terminology and did not find what I was looking for. Input based on a recent podcast with Mike. Thanks for the inspiration @MikeMcQuaid - I would love to continue to help with my favorite macOS tool 馃憣.

Further terminology in docs + link on README
Addressing a few spots where I looked for terminology and did not find what I was looking for. Input based on a recent [podcast with Mike](https://changelog.com/podcast/223)
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 13, 2016

Lovely, cheers @mjbrender! Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit 1d27fda into Homebrew:master Oct 13, 2016

4 checks passed

codecov/patch Coverage not affected when comparing 62e44a1...b84ec63
Details
codecov/project 63.02% (+0.00%) compared to 62e44a1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@mbbroberg mbbroberg deleted the mbbroberg:glossary branch Oct 13, 2016

@mbbroberg

This comment has been minimized.

Copy link
Contributor Author

mbbroberg commented Oct 13, 2016

You made my freaking day @MikeMcQuaid 馃憣. Looking forward to helping where I can.

@tdsmith

This comment has been minimized.

Copy link
Contributor

tdsmith commented Nov 10, 2016

I just noticed this change! It's really great! Thanks for this :)

@mbbroberg

This comment has been minimized.

Copy link
Contributor Author

mbbroberg commented Dec 3, 2016

Thanks @tdsmith! So happy that you all welcome contribution from the community. I 鉂わ笍 Homebrew.

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.