New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve updating behaviour #13299
Improve updating behaviour #13299
Conversation
Review period will end on 2022-05-19 at 19:58:52 UTC. |
3e063d6
to
3cf3307
Compare
3d993ae
to
669a746
Compare
Outside of the environment variable description mentioned above, this looks good to me. I tested out this branch and I like the configurability the new environment variables allow (they work as expected for my use case). The installed-only |
e573413
to
c597a12
Compare
c597a12
to
4da37f1
Compare
- Rename use of "preinstall" to "auto update". The original "preinstall" naming came from the fact that we used to only auto-update before `brew install` but now that it's many commands: this is more confusing than useful. - Add `HOMEBREW_NO_UPDATE_REPORT_ONLY_INSTALLED` and remove `HOMEBREW_UPDATE_REPORT_ONLY_INSTALLED`; the latter is now the default and the prior provides an opt-out for better output, performance and avoiding reading potentially untrusted formulae. - Add `HOMEBREW_UPDATE_FORMULA_VERSION_CHECKS` and don't check formula versions by default for better performance by default. Co-authored-by: Eric Knibbe <3324775+EricFromCanada@users.noreply.github.com> Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
4da37f1
to
fb4c935
Compare
Review period ended. |
LGTM! |
brew install
but now that it's many commands: this is more confusing than useful.HOMEBREW_NO_UPDATE_REPORT_ONLY_INSTALLED
and removeHOMEBREW_UPDATE_REPORT_ONLY_INSTALLED
; the latter is now the default and the prior provides an opt-out for better output, performance and avoiding reading potentially untrusted formulae.HOMEBREW_UPDATE_FORMULA_VERSION_CHECKS
and don't check formula versions by default for better performance by default.CC @boblail for thoughts.