New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat/sha1: disable SHA-1 support. #1451

Merged
merged 1 commit into from Nov 6, 2016

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Nov 6, 2016

This has been deprecated for quite a while now so disabling seems reasonable.

compat/sha1: disable SHA-1 support.
This has been deprecated for quite a while now so disabling seems
reasonable.

@MikeMcQuaid MikeMcQuaid merged commit 58f21b5 into Homebrew:master Nov 6, 2016

4 checks passed

codecov/patch Coverage not affected when comparing ce2b11f...fcaa48d
Details
codecov/project 60.61% (+0.00%) compared to ce2b11f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@MikeMcQuaid MikeMcQuaid removed the in progress label Nov 6, 2016

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:disable-sha1 branch Nov 6, 2016

@robinbowes

This comment has been minimized.

Copy link

robinbowes commented Nov 7, 2016

Er, this breaks stuff, eg. any recipe that still uses SHA1.

Did you specify a date by when you were going to disable SHA1? If not, this seems a little unreasonable.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Nov 7, 2016

Let's keep conversation in Homebrew/homebrew-core#6677.

@Homebrew Homebrew locked and limited conversation to collaborators Nov 7, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.