From a480982e757dd5e97e16b93189c3460c806ce6d3 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 29 Mar 2023 00:40:46 +0100 Subject: [PATCH] dev-cmd/tests: Deal with `TODO` for a BuildPulse bug that's fixed - This does what the comment told us to do, use the bang variant of `system_command` to not swallow the errors. --- Library/Homebrew/dev-cmd/tests.rb | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/dev-cmd/tests.rb b/Library/Homebrew/dev-cmd/tests.rb index af59988836e9f..4cf7b5836873b 100644 --- a/Library/Homebrew/dev-cmd/tests.rb +++ b/Library/Homebrew/dev-cmd/tests.rb @@ -60,13 +60,12 @@ def run_buildpulse ohai "Sending test results to BuildPulse" - # TODO: make this use `system_command!` when https://github.com/buildpulse/buildpulse-action/issues/4 is fixed - system_command Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter", - args: [ - "submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit", - "--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"), - "--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID") - ] + system_command! Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter", + args: [ + "submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit", + "--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"), + "--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID") + ] end def changed_test_files