New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: don't allow use of OS.mac?/OS.linux?. #1674

Merged
merged 1 commit into from Dec 18, 2016

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Dec 15, 2016

Forbid their use in Homebrew/core which only supports macOS. This may be added to more/all official taps in future.

@MikeMcQuaid MikeMcQuaid changed the title audit: flag use of "fails_with :llvm". audit: don't allow use of OS.mac?/OS.linux?. Dec 15, 2016

audit: don't allow use of OS.mac?/OS.linux?.
Forbid their use in Homebrew/core which only supports macOS. This may
be added to more/all official taps in future.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:audit-os-mac-linux branch from e1c30a3 to 339ff94 Dec 18, 2016

@MikeMcQuaid MikeMcQuaid merged commit 0027ded into Homebrew:master Dec 18, 2016

1 of 3 checks passed

codecov/patch 25.00% of diff hit (target 63.14%)
Details
codecov/project 63.12% (-0.02%) compared to 201b45d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-os-mac-linux branch Dec 18, 2016

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.