New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: don't allow universal for new formulae. #1844

Merged
merged 1 commit into from Jan 17, 2017

Conversation

Projects
None yet
4 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 15, 2017

We're frowning on these now so may as well turn that into code.

CC @ilovezfs who inspired this.

audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.

@MikeMcQuaid MikeMcQuaid merged commit aa10413 into Homebrew:master Jan 17, 2017

1 of 3 checks passed

codecov/patch 0.00% of diff hit (target 63.02%)
Details
codecov/project 63.01% (-0.01%) compared to 1296074
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-universal branch Jan 17, 2017

@@ -481,6 +481,10 @@ def audit_options

next unless @strict

if o.name == "universal"
problem "macOS has been 64-bit only since 10.6 so universal options are deprecated."

This comment has been minimized.

@bfontaine

bfontaine Jan 17, 2017

Member

Shouldn’t that use an hyphen (64-bit-only)?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jan 17, 2017

Member

I think it's fine either way.

This comment has been minimized.

@RandomDSdevel

RandomDSdevel Jan 23, 2017

Contributor

You could do '64-bit–only' (first a normal hyphen/hyphen-minus, then an en dash,) per section 1.2.1.3 of Wikipedia's article on dashes, but, as noted there near the bottom, that can be somewhat controversial and should only be used to disambiguate when necessary. My gut feeling says that said disambiguation would increase readability, even if only slightly, here, though maybe I'm just hungry…; in any case, it's your guys's call to make, and probably in a future PR, as well, as you closed this one. Feel free to ignore my nit-picking if you wish.

@yan12125 yan12125 referenced this pull request Feb 14, 2017

Merged

python3: CPython has migrated to GitHub #9961

2 of 4 tasks complete

ilovezfs referenced this pull request in Homebrew/homebrew-core Feb 17, 2017

sqlite 3.17.0
Closes #9928.

Signed-off-by: Tomasz Pajor <tomek@polishgeeks.com>

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.