New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Minitest. #2233

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
3 participants
@reitermarkus
Copy link
Member

reitermarkus commented Feb 28, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

After only 12504 lines of code, all tests are now converted. 馃帀

@reitermarkus reitermarkus force-pushed the reitermarkus:remove-minitest branch from 6ca571c to b775c78 Feb 28, 2017

@MikeMcQuaid
Copy link
Member

MikeMcQuaid left a comment

Amazing work. I'm really impressed you got this done as quickly as you did.

@@ -1,4 +1,4 @@
#: * `tests` [`-v`] [`--coverage`] [`--generic`] [`--no-compat`] [`--only=`<test_script>`:`<test_method>] [`--seed` <seed>] [`--trace`] [`--online`] [`--official-cmd-taps`]:
#: * `tests` [`-v`] [`--coverage`] [`--generic`] [`--no-compat`] [`--only=`<test_name>] [`--seed` <seed>] [`--online`] [`--official-cmd-taps`]:

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Feb 28, 2017

Member

No longer possible to run single tests?

This comment has been minimized.

@reitermarkus

reitermarkus Feb 28, 2017

Member

Doesn't seem possible when using parallel_rspec. Maybe @alyssais knows more?

A workaround would be to run default rspec when only a single test should be run.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Feb 28, 2017

Member

A workaround would be to run default rspec when only a single test should be run.

馃憤 from me.

This comment has been minimized.

@alyssais

alyssais Feb 28, 2017

Contributor

Wouldn't be surprised if that wasn't possible with parallel_rspec since it likes to treat files as being the lowest division of tests (though I haven't checked). Workaround is probably best.

@reitermarkus reitermarkus force-pushed the reitermarkus:remove-minitest branch from b775c78 to fafef58 Feb 28, 2017

@reitermarkus reitermarkus force-pushed the reitermarkus:remove-minitest branch from fafef58 to 487294f Feb 28, 2017

@reitermarkus reitermarkus merged commit 9d67afb into Homebrew:master Mar 1, 2017

@reitermarkus reitermarkus deleted the reitermarkus:remove-minitest branch Mar 1, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.