config: show Windows build on WSL#22398
Open
MikeMcQuaid wants to merge 1 commit into
Open
Conversation
- read Edition, display version and build from registry - expose the host Windows version in `brew config` - fall back to `ver` when registry output is unavailable
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends brew config on Linux/WSL to expose the host Windows version/build, primarily by querying the Windows registry via cmd.exe (with a fallback to ver when registry data is unavailable).
Changes:
- Add a
SystemConfig.windows_versionAPI returning the host Windows version string on WSL. - Implement Windows version detection on Linux/WSL using
reg query(plusverfallback) and print it in verbose config output. - Add RSpec coverage for parsing/formatting the Windows version and for the additional
brew configoutput line on WSL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Library/Homebrew/test/cmd/config_spec.rb |
Adds tests for WSL Windows-version detection and for the new verbose config output line. |
Library/Homebrew/system_config.rb |
Introduces a windows_version method on SystemConfig (default nil). |
Library/Homebrew/extend/os/linux/system_config.rb |
Implements WSL Windows version detection (registry + ver fallback) and prints it in dump_verbose_config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew configverwhen registry output is unavailablebrew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing.