New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Cask specs into `brew tests`. #2260

Merged
merged 4 commits into from Mar 5, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Copy link
Member

reitermarkus commented Mar 5, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@reitermarkus reitermarkus force-pushed the reitermarkus:spec-cask branch 3 times, most recently from 0e98262 to a39af59 Mar 5, 2017

@@ -23,23 +23,5 @@ def run_tests(executable, files, args = [])

if ARGV.flag?("--coverage")
ENV["HOMEBREW_TESTS_COVERAGE"] = "1"

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Mar 5, 2017

Member

What does brew cask-tests do now?

This comment has been minimized.

@reitermarkus

reitermarkus Mar 5, 2017

Member

Nothing, but it is still needed because test-bot still calls it.

@reitermarkus reitermarkus force-pushed the reitermarkus:spec-cask branch 8 times, most recently from db058ac to be17abc Mar 5, 2017

@reitermarkus reitermarkus force-pushed the reitermarkus:spec-cask branch from be17abc to eed5a69 Mar 5, 2017

@reitermarkus

This comment has been minimized.

Copy link
Member

reitermarkus commented Mar 5, 2017

Finally coverage is (seems to be, at least 😉 ) working.

@reitermarkus reitermarkus merged commit 1fbd720 into Homebrew:master Mar 5, 2017

2 of 3 checks passed

codecov/project 62.33% (-0.84%) compared to 67ec76d
Details
codecov/patch Coverage not affected when comparing 67ec76d...eed5a69
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:spec-cask branch Mar 5, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Mar 6, 2017

@reitermarkus Nice work 👏

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.