New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: deprecate language module requirements. #2473

Merged
merged 1 commit into from Apr 17, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 11, 2017

Make brew audit complain about language module requirements because they provide a crappy user experience compared to vendoring and we’re not really fixing bugs in them any more.

CC @ilovezfs as we discussed this.

audit: deprecate language module requirements.
Make `brew audit` complain about language module requirements because
they provide a crappy user experience compared to vendoring and we’re
not really fixing bugs in them any more.
@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Apr 11, 2017

Did anyone ever work out how to actually vendor lua dependencies sensibly?

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

@DomT4 Not that I know of. Why are they problematic?

@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Apr 11, 2017

@ilovezfs I ended up being the Lua point person & I don't even write Lua that much, so I've always asked others to step in on this with more knowledge and nobody showed even the slightest bit of interest in doing so 😅, but I had a hard time years ago with getting vendored Lua stuff to play completely consistently for as many use cases as a package manager serves.

I'll check out the one => :lua formula in the core again shortly. I know more about handling Lua than I used to, alas 😄.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

2

corsixth.rb
19:  depends_on "lpeg" => :lua
20:  depends_on "luafilesystem" => :lua

sile.rb
24:  depends_on "lpeg" => :lua
25:  depends_on "luaexpat" => :lua
26:  depends_on "luafilesystem" => :lua
@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Apr 11, 2017

Ouch, when did that second one sneak in 😸. I'll look at sile first, that was the historical PITA (a term I use with affection) with the lua stuff.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

    corsixth: import from homebrew/games.
@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

In the last thirty days,
15 unique installs for sile (of which 7 were sile --HEAD)
29 for corsixth

So if it's at all a burden we may just want to send them to the formula glue factory.

@DomT4 DomT4 referenced this pull request Apr 11, 2017

Closed

sile: vendor resources #12326

3 of 3 tasks complete
@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Apr 11, 2017

sile is a fairly special pain but an example of how things would need to be done is in Homebrew/homebrew-core#12326.

Note that luarocks broadly requires network access. It fetches this file & the related rockspec for each lua resource. Not a huge deal, and not something we can take away from luarocks as far as I'm aware, just an FYI.

@MikeMcQuaid MikeMcQuaid merged commit 29b54dc into Homebrew:master Apr 17, 2017

2 of 3 checks passed

codecov/patch 50% of diff hit (target 61.69%)
Details
codecov/project 62.37% (+0.68%) compared to 5d74069
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:audit-language-module-requirements branch Apr 17, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.