New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap: warn on tapping deprecated, official taps. #2480

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 11, 2017

They don't contain any formulae so tapping them will add pointless clutter.

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Apr 11, 2017

Won't this cause some tap migrations to be missed if someone has untapped the tap of an installed keg that has subsequently been migrated to a different tap?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 17, 2017

@ilovezfs Yes, perhaps. Need to test and perhaps come up with a better fix for that.

@ilovezfs
Copy link
Contributor

ilovezfs left a comment

if it's a warning

tap: warn on tapping deprecated, official taps.
They don't contain any formulae so tapping them will add pointless
clutter.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:no-tap-deprecate-taps branch from 9de4eb7 to e04cb89 Apr 22, 2017

@MikeMcQuaid MikeMcQuaid changed the title tap: don't tap deprecated, official taps. tap: warn on tapping deprecated, official taps. Apr 22, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 22, 2017

Decided to just make this warn instead of failing.

@MikeMcQuaid MikeMcQuaid merged commit 1ceb420 into Homebrew:master Apr 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:no-tap-deprecate-taps branch Apr 22, 2017

kdeldycke added a commit to kdeldycke/dotfiles that referenced this pull request May 2, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.