New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More deprecations. #2522

Merged
merged 1 commit into from Apr 22, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 21, 2017

Deprecate more methods. Internal APIs have been verified to be unused elsewhere and removed. External APIs have had deprecation methods added. Existing deprecations have been either upgraded to produce warnings or no longer deprecated and the reasoning documented.

# Xcode.version with an Xcode.installed? check.
# The remaining logic provides a fake Xcode version based on the
# installed CLT version. This is useful as they are packaged
# simultanously so workarounds need to apply to both based on their

This comment has been minimized.

@ilovezfs

ilovezfs Apr 21, 2017

Contributor

simultaneously

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Apr 21, 2017

Member

So simultaneous was this that a spelling mistake was unavoidable.

(thanks!)

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecations branch from 8bf65aa to cf58dcb Apr 21, 2017

def shell_profile
opoo "shell_profile has been deprecated in favor of Utils::Shell.profile"
odeprecated "shell_profile", "Utils::Shell.profile"

This comment has been minimized.

@reitermarkus

reitermarkus Apr 22, 2017

Member

Why are we not calling Utils::Shell.profile here?

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecations branch 6 times, most recently from d820a78 to 597598b Apr 22, 2017

More deprecations.
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:more-deprecations branch from 597598b to ba3c46d Apr 22, 2017

@MikeMcQuaid MikeMcQuaid merged commit a937ed0 into Homebrew:master Apr 22, 2017

3 checks passed

codecov/patch 88.09% of diff hit (target 63.97%)
Details
codecov/project 64.02% (+0.05%) compared to 044bd97
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:more-deprecations branch Apr 22, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.