New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Port audit_caveats method to rubocop and add tests #2664

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
3 participants
@GauthamGoli
Copy link
Member

GauthamGoli commented May 22, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#569

alyssais pushed a commit to alyssais/brew that referenced this pull request May 22, 2017

caveats_node = find_method_def(body_node, :caveats)
return if caveats_node.nil?
caveats_string_nodes = find_strings(caveats_node)
caveats_string_nodes.each do |n|

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid May 25, 2017

Member

Would be good if we could get all the caveats strings nodes as a single method call?

@GauthamGoli GauthamGoli force-pushed the GauthamGoli:audit_caveats_rubocop branch from 8ece769 to 03ca24d May 28, 2017

@GauthamGoli GauthamGoli force-pushed the GauthamGoli:audit_caveats_rubocop branch from 03ca24d to cf848a1 Jun 2, 2017

@MikeMcQuaid MikeMcQuaid merged commit ce80485 into Homebrew:master Jun 2, 2017

3 checks passed

codecov/patch Coverage not affected when comparing daa6788...cf848a1
Details
codecov/project 64.33% (+<.01%) compared to daa6788
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jun 2, 2017

Thanks again @GauthamGoli!

@JCount

This comment has been minimized.

Copy link
Contributor

JCount commented Jun 2, 2017

Congratulations on another PR, and thank you @GauthamGoli! 😄

fcolasuonno-bbc added a commit to fcolasuonno-bbc/brew that referenced this pull request Aug 2, 2017

mansimarkaur added a commit to mansimarkaur/brew that referenced this pull request Aug 5, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.