New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parallel RuboCop #2679

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented May 25, 2017

This requires updating to Rubocop 0.49.0 which will require some fixes to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this for now so I remember.

CC @reitermarkus @GauthamGoli who may have thoughts on implementation.

@reitermarkus

This comment has been minimized.

Copy link
Member

reitermarkus commented May 25, 2017

There seem to be a few new rules, I'll take a look later today.

@reitermarkus

This comment has been minimized.

Copy link
Member

reitermarkus commented May 25, 2017

So, -P/--parallel can not be combined with --auto-correct.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from a661b25 to 3e116b5 May 27, 2017

@MikeMcQuaid MikeMcQuaid requested a review from reitermarkus May 27, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 27, 2017

The other thing I need to make sure here (to make a mental note) is that the various taps have their issues fixed before this is merged (once we're agreed on rules).

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from 3e116b5 to 01b6563 May 27, 2017

:trash,
:rmdir,
].freeze
ORDERED_DIRECTIVES = %i(

This comment has been minimized.

@reitermarkus

reitermarkus May 27, 2017

Member

I say we change this cop to enforce brackets instead. It's much easier to grep for symbols than to have to remember that there may be a symbol array which contains it.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid May 28, 2017

Member

Works for me.

@@ -1,3 +1,3 @@
# RuboCop version used for `brew style` and `brew cask style`
HOMEBREW_RUBOCOP_VERSION = "0.47.1".freeze
HOMEBREW_RUBOCOP_VERSION = "0.49.0".freeze
HOMEBREW_RUBOCOP_CASK_VERSION = "~> 0.12.0".freeze # has to be updated when RuboCop version changes

This comment has been minimized.

@reitermarkus

reitermarkus May 27, 2017

Member

I bumped rubocop-cask to 0.13.0.

--color
--require spec_helper
--format progress
--format ParallelTests::RSpec::RuntimeLogger
--out tmp/parallel_runtime_rspec.log
--out #{ENV["HOME"]}/.cache/parallel_rspec/runtime.log

This comment has been minimized.

@reitermarkus

reitermarkus May 27, 2017

Member

Doesn't tmp work anymore?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid May 28, 2017

Member

@reitermarkus It does but I think it's misleading; the other files are actually temporary whereas this runtime log is (like RuboCop's) a cache entry that massive speeds things up if it exists.

This comment has been minimized.

@reitermarkus

reitermarkus May 28, 2017

Member

Ok, could we use HOMEBREW_CACHE then? I really don't want yet another dotfile in my home directory. And we can still set HOMEBREW_CACHE to $HOME/.cache on Travis.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid May 28, 2017

Member

If you can make Rubocop use it too: sure.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from 01b6563 to 84a06a1 May 28, 2017

reitermarkus added a commit to reitermarkus/brew that referenced this pull request May 28, 2017

Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.

CC @reitermarkus @GauthamGoli who may have thoughts on implementation.

Closes Homebrew#2679.

Signed-off-by: Markus Reiter <me@reitermark.us>

reitermarkus added a commit to reitermarkus/brew that referenced this pull request May 28, 2017

Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.

CC @reitermarkus @GauthamGoli who may have thoughts on implementation.

Closes Homebrew#2679.

Signed-off-by: Markus Reiter <me@reitermark.us>

@reitermarkus reitermarkus referenced this pull request May 28, 2017

Merged

Use `XDG_CACHE_HOME` for RuboCop. #2690

3 of 5 tasks complete

@reitermarkus reitermarkus force-pushed the MikeMcQuaid:parallel-rubocop branch from 84a06a1 to 51daac3 May 29, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 29, 2017

@reitermarkus Are you 🆗 with this now?

@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented May 29, 2017

0.49.1 has landed now FYI.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 29, 2017

Ta @DomT4. Will ship that when this is green.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from 86c3763 to 5dfdfe7 May 29, 2017

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from 5dfdfe7 to cbe816e May 29, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 29, 2017

@reitermarkus I've pushed the changes to use HOMEBREW_CACHE for parallel rspec usage, too.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from cbe816e to 0cdeedc May 29, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 29, 2017

@reitermarkus Can you hold off any merges until this is green please?

Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:parallel-rubocop branch from 0cdeedc to 7a38bab May 29, 2017

@reitermarkus

This comment has been minimized.

Copy link
Member

reitermarkus commented May 29, 2017

Can you hold off any merges until this is green please?

Yes, sorry. 😬

@MikeMcQuaid MikeMcQuaid merged commit 744e7dd into Homebrew:master May 29, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 3165fd2...7a38bab
Details
codecov/project 64.4% (+0.01%) compared to 3165fd2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented May 29, 2017

@reitermarkus Good now, thanks!

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:parallel-rubocop branch May 29, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.