New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined local variable or method `ruby_version' on macOS 10.13 beta #2738

Merged
merged 2 commits into from Jun 6, 2017

Conversation

Projects
None yet
3 participants
@constXife
Copy link
Contributor

constXife commented Jun 6, 2017

There is a bug in check_ruby_version. It occur on MacOS 10.13 beta because it ships with Ruby 2.3.3.

I didn't figure up how to make brew tests work, but i made some workarounds changes to check my code and it should to be work.

Fixes #2737

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.

constXife and others added some commits Jun 6, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jun 6, 2017

Great work here @constXife! Thanks for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit d9abe65 into Homebrew:master Jun 6, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 576eb74...24d3943
Details
codecov/project 65.13% (+0.01%) compared to 576eb74
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@walterpalladino

This comment has been minimized.

Copy link

walterpalladino commented Apr 16, 2018

Anyone get a solution for this?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Apr 16, 2018

@walterpalladino It was fixed almost a year ago. brew update, brew update-reset or reinstall Homebrew.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.