audit: Port audit_conflicts method to rubocop and add tests #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GauthamGoli
force-pushed
the
audit_conflicts_rubocop
branch
from
f0f645d
to
4f30de4
Compare
MikeMcQuaid
requested changes
Jun 30, 2017
| # This cop audits versioned Formulae for `conflicts_with` | ||
| class Conflicts < FormulaCop | ||
| MSG = <<-EOS.undent | ||
| Versioned formulae should not use `conflicts_with`. |
There was a problem hiding this comment.
Only indent by two characters here.
|
|
||
| def audit_formula(_node, _class_node, _parent_class_node, body) | ||
| return unless versioned_formula? | ||
| whitelist = %w[node@ bash-completion@].freeze |
There was a problem hiding this comment.
Let's make this a constant earlier in the class and have one formula per line so they stand out a bit more
GauthamGoli
force-pushed
the
audit_conflicts_rubocop
branch
2 times, most recently
from
8a9f570
to
0db695e
Compare
MikeMcQuaid
approved these changes
Jul 7, 2017
MikeMcQuaid
requested changes
Jul 7, 2017
| EOS | ||
|
|
||
| WHITELIST = %w[node@ | ||
| bash-completion@].freeze |
There was a problem hiding this comment.
Let's go for:
WHITELIST = %w[
node@
bash-completion@
].freezeThere was a problem hiding this comment.
that will reduce the diff on future additions here.
There was a problem hiding this comment.
Waoh. Never thought of that!
|
@MikeMcQuaid I'm moving the two private methods defined in |
GauthamGoli
force-pushed
the
audit_conflicts_rubocop
branch
from
0db695e
to
4ed34f9
Compare
MikeMcQuaid
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?#569
This PR partially ports
audit_conflictsmethod to a custom cop. Remaining code inaudit_conflictsuses Homebrew internals methods and I could not figure out their exact functionality to port them. Please let me know if this approach is not good.