New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `brew tests` on High Sierra. #2872

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jul 7, 2017

The brew test tests were failing as they were unable to include test/unit/assertions. This is because it's a gem and we were setting the GEM_HOME so system gems were being ignored.

While I was there and examining the $LOAD_PATH: reduce the number of things we add there by using Bundler.with_clean_env and only adding HOMEBREW_LIBRARY_PATH in the $LOAD_PATH if it isn't already there (which it always is [and has to be] for integration tests).

This also seems to have the side effect of speeding up integration tests from 1m26s to 1m8s on my machine.

Fix `brew tests` on High Sierra.
The `brew test` tests were failing as they were unable to include
`test/unit/assertions`. This is because it's a gem and we were setting
the `GEM_HOME` so system gems were being ignored.

While I was there and examining the `$LOAD_PATH`: reduce the number of
things we add there by using `Bundler.with_clean_env` and only adding
`HOMEBREW_LIBRARY_PATH` in the `$LOAD_PATH` if it isn't already there
(which it always is [and has to be] for integration tests).

This also seems to have the side effect of speeding up integration
tests from 1m26s to 1m8s on my machine.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:fix-high-sierra-tests branch from fb5b5bb to 9c0960e Jul 9, 2017

integration_test: add simplecov libs when needed.
Don't add these unconditionally or with Bundler to speed things up a
bit. Also, to speed things up further cache these arguments so we don't
have to do the same generation every time.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:fix-high-sierra-tests branch from 9c0960e to cabb7e8 Jul 10, 2017

@MikeMcQuaid MikeMcQuaid merged commit 287ba7a into Homebrew:master Jul 10, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 4cb8391...cabb7e8
Details
codecov/project 65.64% remains the same compared to 4cb8391
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:fix-high-sierra-tests branch Jul 10, 2017

MikeMcQuaid added a commit to MikeMcQuaid/brew that referenced this pull request Jul 13, 2017

tests: unpin bundler.
These issues were fixed by Homebrew#2872
and Homebrew#2823.

@MikeMcQuaid MikeMcQuaid referenced this pull request Jul 13, 2017

Merged

tests: unpin bundler. #2893

fcolasuonno-bbc added a commit to fcolasuonno-bbc/brew that referenced this pull request Aug 2, 2017

tests: unpin bundler.
These issues were fixed by Homebrew#2872
and Homebrew#2823.

mansimarkaur added a commit to mansimarkaur/brew that referenced this pull request Aug 5, 2017

tests: unpin bundler.
These issues were fixed by Homebrew#2872
and Homebrew#2823.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.