New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List cask full-names #2878

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Projects
None yet
3 participants
@wendorf
Contributor

wendorf commented Jul 9, 2017

brew cask list supports the --full-name flag which will include the tap name for casks not part of the core caskroom/cask tap. For example, if cask "foo-beta" is installed from the caskroom/versions cask, brew cask list --full-name will report the name as "caskroom/versions/foo-beta".

This will be especially helpful with brew bundle cleanup, which currently cannot correctly identify a cask installed from a non-core tap.

Show outdated Hide outdated Library/Homebrew/test/cask/cli/list_spec.rb Outdated
Show outdated Hide outdated Library/Homebrew/formula.rb Outdated
Show outdated Hide outdated Library/Homebrew/test/support/helper/spec/shared_context/homebrew_cask.rb Outdated
Show outdated Hide outdated Library/Homebrew/cask/lib/hbc/cask.rb Outdated
@MikeMcQuaid

LGTM once @reitermarkus has 👍d Cask bits.

@reitermarkus reitermarkus referenced this pull request Jul 29, 2017

Merged

Detect `Tap` in `CaskLoader`. #2965

4 of 5 tasks complete

@stale stale bot added the stale label Aug 26, 2017

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Aug 26, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale bot commented Aug 26, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot removed the stale label Aug 27, 2017

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Sep 10, 2017

Member

@wendorf, one small change, and this should be good to go.

Member

reitermarkus commented Sep 10, 2017

@wendorf, one small change, and this should be good to go.

List cask full-names
`brew cask list` supports the `--full-name` flag which will include the tap
name for casks not part of the core caskroom/cask tap. For example, if
cask "foo-beta" is installed from the caskroom/versions cask, `brew cask
list --full-name` will report the name as "caskroom/versions/foo-beta".
@wendorf

This comment has been minimized.

Show comment
Hide comment
@wendorf

wendorf Sep 16, 2017

Contributor

@reitermarkus Thanks for the additional feedback. Just did another rebase and push, so hopefully this is ready to be merged!

Contributor

wendorf commented Sep 16, 2017

@reitermarkus Thanks for the additional feedback. Just did another rebase and push, so hopefully this is ready to be merged!

@reitermarkus reitermarkus merged commit dbc4a38 into Homebrew:master Sep 17, 2017

3 checks passed

codecov/patch 92.85% of diff hit (target 67.05%)
Details
codecov/project 67.12% (+0.07%) compared to 01f52f5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus
Member

reitermarkus commented Sep 17, 2017

Thanks, @wendorf!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.