New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: sandbox all taps by default. #2898

Merged
merged 1 commit into from Jul 30, 2017

Conversation

Projects
None yet
4 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jul 14, 2017

We've been doing this in brew test-bot, for our CI and for homebrew/core long enough that this is a reasonable default that provides more protection to our users of non-homebrew/core taps.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 14, 2017

I'll hold off merging this until we plan on shipping 1.3.0.

sandbox: sandbox all taps by default.
We've been doing this in `brew test-bot`, for our CI and for
homebrew/core long enough that this is a reasonable default that
provides more protection to our users of non-homebrew/core taps.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:sandbox-all-taps branch from 9bbf4b6 to fb310c5 Jul 14, 2017

@JCount

JCount approved these changes Jul 15, 2017

@apjanke
Copy link
Contributor

apjanke left a comment

Well, this will be exciting. But welcome.

@MikeMcQuaid MikeMcQuaid merged commit 3821132 into Homebrew:master Jul 30, 2017

3 checks passed

codecov/patch 100% of diff hit (target 65.67%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +34.32% compared to 20db547
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:sandbox-all-taps branch Jul 30, 2017

@nayzak nayzak referenced this pull request Aug 3, 2017

Closed

gem download fails with EPERM #47

chapskev added a commit to chapskev/msphpsql that referenced this pull request Sep 13, 2017

Update README.md
I have determined that the install failure is due to another "security feature" recently introduced into Homebrew --- as of 1.3.0 --- which runs all installers in a restricted sandbox environment: Homebrew/brew#2898

However, you can still disable that with an option, and it will register the driver in odbcinst.ini correctly without having to perform the manual workaround above:

Microsoft/homebrew-mssql-release#1 (comment)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.