New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more deprecations. #2899

Merged
merged 2 commits into from Jul 30, 2017

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jul 14, 2017

It's been long enough that these have been commented out so let's enable them globally.

I'll hold off merging this until we plan on shipping 1.3.0.

@MikeMcQuaid MikeMcQuaid requested a review from reitermarkus Jul 14, 2017

@@ -1,5 +1,5 @@
def shell_profile
# odeprecated "shell_profile", "Utils::Shell.profile"
odeprecated "shell_profile", "Utils::Shell.profile"

This comment has been minimized.

@ilovezfs

ilovezfs Jul 14, 2017

Contributor

seems like a DSL downgrade

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:enable-deprecations branch from dc70a9c to c968782 Jul 14, 2017

# TODO: Uncomment after `license` has been
# removed from all official taps.
# odeprecated "Hbc::DSL#license"
odeprecated "Hbc::DSL#license"

This comment has been minimized.

@reitermarkus

reitermarkus Jul 15, 2017

Member

This should also be moved into compat.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jul 15, 2017

Member

@reitermarkus Mind committing that to this PR? Not sure where the relevant part is for Cask.

This comment has been minimized.

@reitermarkus

MikeMcQuaid and others added some commits Jul 14, 2017

Enable more deprecations.
It's been long enough that these have been commented out so let's
enable them globally.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:enable-deprecations branch from 5115e3f to 9578e29 Jul 21, 2017

@MikeMcQuaid MikeMcQuaid referenced this pull request Jul 28, 2017

Closed

Replace `shell_profile` calls in formulae #16143

3 of 4 tasks complete

@MikeMcQuaid MikeMcQuaid merged commit 896f41f into Homebrew:master Jul 30, 2017

1 of 3 checks passed

codecov/patch 50% of diff hit (target 65.78%)
Details
codecov/project 65.78% (-0.01%) compared to e0560ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:enable-deprecations branch Jul 30, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.