New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Port audit_options strict rules to rubocop and add tests #2901

Merged
merged 1 commit into from Jul 15, 2017

Conversation

Projects
None yet
3 participants
@GauthamGoli
Copy link
Member

GauthamGoli commented Jul 14, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#569
Continuation of #2879
Had to convert the option node to string ( lines 27-28 ) because there is a negative regex match, hence was not able to reuse regex_match_group method which takes the node itself as an argument and does the regex match but the method does not do negative regex match. Please suggest if you think there's a better way to do this.

@GauthamGoli GauthamGoli force-pushed the GauthamGoli:audit_option_rubocop_2 branch from cb2fb6f to f3923f2 Jul 14, 2017

@JCount

JCount approved these changes Jul 15, 2017

@JCount JCount merged commit 83f6183 into Homebrew:master Jul 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 65.67%)
Details
codecov/project 65.74% (+0.06%) compared to 20db547
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JCount

This comment has been minimized.

Copy link
Contributor

JCount commented Jul 15, 2017

@GauthamGoli 🎊 Good work on getting another PR shipped!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.