New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: improve devel spec version parsing #2931

Merged
merged 2 commits into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@JCount
Copy link
Contributor

JCount commented Jul 22, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

term this 'devel spec version style';
also improve dash version style parsing

This adds regex specifically aimed at matching common non-release styles used, to better cover automatic version detection in the devel spec. Consequently, I gave it the name of 'devel spec version style' to try make this intent clear within the code.

I additionally created a specific regex for the 'dash version style' because before these were simply being matched by the regex aimed at OpenSSL, leading to erroneous automatic version detections that had to be manually corrected.

JCount added some commits Jul 21, 2017

version: improve devel spec version parsing
term this 'devel spec version style';
also improve dash version style parsing
verion_spec: add test coverage for devel spec version style
also expand coverage for improved dash version style

@JCount JCount requested review from MikeMcQuaid and ilovezfs Jul 24, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 25, 2017

Nice work @JCount 👏

@MikeMcQuaid MikeMcQuaid merged commit f0ca310 into Homebrew:master Jul 25, 2017

3 checks passed

codecov/patch 100% of diff hit (target 65.78%)
Details
codecov/project 65.79% (+<.01%) compared to 9747bc3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilovezfs
Copy link
Contributor

ilovezfs left a comment

Thanks @JCount

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Jul 25, 2017

@cglong this PR has fixed the version-parsing issue you pointed out in Homebrew/homebrew-core#13980 (comment).

@JCount JCount deleted the JCount:version-devel-parsing-improvements branch Jul 25, 2017

@ilovezfs ilovezfs referenced this pull request Jul 25, 2017

Merged

Remove redundant version specifications 2 #16042

2 of 4 tasks complete

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.