New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Port audit_urls to rubocop and add corresponding tests Part 2 #2932

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@GauthamGoli
Copy link
Member

GauthamGoli commented Jul 23, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#569
And Continuation of #2911 , this PR ports Non strict / Online parts of audit_urls
Opening this PR for review until #2911 gets merged.

@GauthamGoli GauthamGoli force-pushed the GauthamGoli:audit_urls_rubocop_part_2 branch from 2e6116c to 0d74947 Jul 23, 2017

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 25, 2017

Will hold off reviewing until this is rebased on master but thanks for opening early 👍

@GauthamGoli GauthamGoli force-pushed the GauthamGoli:audit_urls_rubocop_part_2 branch from 0d74947 to 2639b6c Jul 25, 2017

@GauthamGoli

This comment has been minimized.

Copy link
Member

GauthamGoli commented Jul 25, 2017

@MikeMcQuaid Its rebased on master now.

@MikeMcQuaid MikeMcQuaid merged commit 733abc7 into Homebrew:master Jul 25, 2017

3 checks passed

codecov/patch 98.24% of diff hit (target 65.86%)
Details
codecov/project 66.12% (+0.26%) compared to 7041f7e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 25, 2017

Great work again @GauthamGoli!

@JCount

This comment has been minimized.

Copy link
Contributor

JCount commented Jul 25, 2017

Good job, once again @GauthamGoli!!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.