New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_support: add provided_pre_high_sierra keg_only #2973

Merged
merged 1 commit into from Jul 30, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Copy link
Contributor

DomT4 commented Jul 29, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Apple ditched at least telnet from High Sierra, and whilst I lean towards thinking PRs shouldn't be accepted for those things before the High Sierra GM release if Homebrew is going to accept them it should probably provide this helper for messaging consistency & common-sense handling.

Ref: Homebrew/homebrew-core#16208

@fxcoudert
Copy link
Member

fxcoudert left a comment

Looks reasonable

@MikeMcQuaid MikeMcQuaid merged commit 0595678 into Homebrew:master Jul 30, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 66.55%)
Details
codecov/project 66.55% (-0.01%) compared to 627b1da
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Jul 30, 2017

Thanks again @DomT4!

@DomT4 DomT4 deleted the DomT4:keg_only_additions branch Jul 30, 2017

@DomT4

This comment has been minimized.

Copy link
Contributor

DomT4 commented Jul 30, 2017

Thanks for merging 🙇. You can always rely on a new version of macOS to get some contribution activity out of me, heh.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.