New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_cellar_checks: check_non_libraries only for new formulae #2997

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 3, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This check is overly opinionated and leads to audit failures no one cares to fix, so let's only run it for new formulae. For example, tcl-tk has failed this audit for years:

$ brew audit tcl-tk
tcl-tk:
  * Non-libraries were installed to "/usr/local/opt/tcl-tk/lib"
    Installing non-libraries to "lib" is discouraged.
    The offending files are:
      /usr/local/opt/tcl-tk/lib/Tk.icns
      /usr/local/opt/tcl-tk/lib/Tk.tiff
Error: 1 problem in 1 formula

@ilovezfs ilovezfs referenced this pull request Aug 3, 2017

Closed

netcdf: migrate from homebrew/science #16223

3 of 4 tasks complete
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Aug 3, 2017

Could we make this a --new-formula check?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Aug 3, 2017

(NOOOOO is a reasonable response 😆)

formula_cellar_checks: check_non_libraries only for new formulae
This check is overly opinionated and leads to audit failures no one
cares to fix, so let's only run it for new formulae.

@ilovezfs ilovezfs changed the title formula_cellar_checks: remove check_non_libraries formula_cellar_checks: check_non_libraries only for new formulae Aug 3, 2017

@ilovezfs ilovezfs force-pushed the ilovezfs:non-libraries branch from 60a5640 to ee6b0e7 Aug 3, 2017

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Aug 3, 2017

@MikeMcQuaid yes, it's always good to have extra reasons to reject new formulae.

@ilovezfs ilovezfs merged commit 1cae6dd into Homebrew:master Aug 3, 2017

3 checks passed

codecov/patch 100% of diff hit (target 51.66%)
Details
codecov/project 52.04% (+0.37%) compared to 2ad03b8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.