New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note cases when pinned formulae get upgraded. #3043

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Aug 11, 2017

CC @alexrussell @ilovezfs for thoughts.

Fixes #3021.

@alexrussell

This comment has been minimized.

Copy link

alexrussell commented Aug 11, 2017

@MikeMcQuaid this is good, and thanks for adding it.

Being as you asked for my thoughts, personally, I feel that this message still doesn't make it absolutely clear in some situations.

In the ruby command help and Manpage I'd change it to something like this:

Pin the specified , preventing them from being upgraded when issuing the brew upgrade <formulae> command. See also unpin.
Please note that pinning a formula does not prevent it from being upgraded if a package that relies on it is upgraded, as we do not allow formulae to be built against non-latest versions.

The note in the FAQ is alright in terms of getting the point across (though I still feel like it's not quite as clear as it could be, but cannot offer a better revision right now).

That said, if you don't agree with my revisions here, having something is better than nothing so I'm happy enough with what you already have.

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Aug 12, 2017

Cheers for the review and feedback. Want to try and keep the manpage terse for now so 🚢ing as is but may consider fleshing it out if there's future confusion.

@MikeMcQuaid MikeMcQuaid merged commit a757f43 into Homebrew:master Aug 12, 2017

3 checks passed

codecov/patch Coverage not affected when comparing d6d681c...0e3f1ab
Details
codecov/project 66.64% remains the same compared to d6d681c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:pin-upgrade branch Aug 12, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.