New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: explain why it takes the time it does. #3059

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
None yet
4 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Aug 14, 2017

Provide a bit of clarity that this isn't just searching a local database but doing an GitHub API and Git history query.

Fixes #3056.

@MikeMcQuaid MikeMcQuaid referenced this pull request Aug 14, 2017

Closed

brew search take 30+ seconds #3056

4 of 4 tasks complete
search: explain why it takes the time it does.
Provide a bit of clarity that this isn't just searching a local database
but doing an GitHub API and Git history query.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:why-search-take-so-long branch from 7eb2ab3 to 961d790 Aug 15, 2017

@MikeMcQuaid MikeMcQuaid merged commit 8518ffd into Homebrew:master Aug 15, 2017

3 checks passed

codecov/patch 75% of diff hit (target 66.63%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +8.36% compared to 60d8218
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:why-search-take-so-long branch Aug 15, 2017

@ilovezfs

This comment has been minimized.

Copy link
Contributor

ilovezfs commented Aug 21, 2017

Not sure if this was intentional but it's causing a pretty annoying message to be printed by brew audit:

iMac-TMP:Homebrew joe$ brew audit argyll-cms --strict --online
==> Searching taps on GitHub...
iMac-TMP:Homebrew joe$ 

MikeMcQuaid added a commit to MikeMcQuaid/brew that referenced this pull request Aug 23, 2017

audit: don't output when searching taps.
This messaging was added for the `brew search` command and having it in
audit is annoying:
(Homebrew#3059 (comment))

As a side note: this is why randomly including `cmd/*` is a bad idea.
@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Aug 23, 2017

@ilovezfs Not intentional, fixed in #3086.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.