New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Port line_problems to rubocop and add tests part 3 #3091

Merged
merged 3 commits into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@GauthamGoli
Member

GauthamGoli commented Aug 26, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

#569 and continuation of #2995

Suggestions for any edge test cases are needed as I may not be aware of all of them.

@MikeMcQuaid

Looking good! A few minor changes.

Show outdated Hide outdated Library/Homebrew/rubocops/extend/formula_cop.rb Outdated
Show outdated Hide outdated Library/Homebrew/rubocops/lines_cop.rb Outdated
Show outdated Hide outdated Library/Homebrew/rubocops/lines_cop.rb Outdated
Show outdated Hide outdated Library/Homebrew/rubocops/lines_cop.rb Outdated
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 5, 2017

Member

Thanks again @GauthamGoli!

Member

MikeMcQuaid commented Sep 5, 2017

Thanks again @GauthamGoli!

@MikeMcQuaid MikeMcQuaid merged commit bf0ab93 into Homebrew:master Sep 5, 2017

3 checks passed

codecov/patch 100% of diff hit (target 53.93%)
Details
codecov/project Absolute coverage decreased by -2.37% but relative coverage increased by +46.06% compared to 751334a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Sep 5, 2017

Member

Thanks, and good work this summer!

Member

JCount commented Sep 5, 2017

Thanks, and good work this summer!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.