Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport High Sierra #3121
Conversation
fxcoudert
force-pushed the
fxcoudert:highsierra
branch
from
0ba8285
to
57f4c7f
Sep 4, 2017
This comment has been minimized.
This comment has been minimized.
We can wait for the GM ;) |
MikeMcQuaid
added
the
do not merge
label
Sep 4, 2017
This comment has been minimized.
This comment has been minimized.
Yes, I want to wait for at least the GM if not the actual release. Apple still changes stuff under us right up until the GM and we don't have any CI boxes yet so we really can't claim to provide any level of support yet. |
MikeMcQuaid
reviewed
Sep 4, 2017
@@ -195,7 +195,7 @@ def check_for_other_package_managers | |||
end | |||
|
|||
def check_ruby_version | |||
ruby_version = "2.0" | |||
ruby_version = MacOS.version >= "10.13" ? "2.3" : "2.0" |
This comment has been minimized.
This comment has been minimized.
MikeMcQuaid
Sep 4, 2017
Member
I don't want to go back to supporting different Ruby versions in different places. CC @mistydemeo how's the Ruby 2.3.3p222
stuff looking? CC @alyssais @xu-cheng in case either of you have been working on the portable Ruby recently, either.
This comment has been minimized.
This comment has been minimized.
xu-cheng
Sep 4, 2017
Contributor
I don't think there is any problem for portable ruby 2.3. except that you have to build it on your own (I don't have access to 10.5 VM).
This comment has been minimized.
This comment has been minimized.
I'm happy with waiting for the GM. Just for the sake of data: 10.13 currently represents 11% of our installs, compared to 75% for 10.12, 12% for 10.11, and 2.6% for 10.10. |
This comment has been minimized.
This comment has been minimized.
Doesn't usually stop them much, to be honest |
This comment has been minimized.
This comment has been minimized.
bai
commented
Sep 14, 2017
GM has been just released. Any blockers on getting this shipped? |
This comment has been minimized.
This comment has been minimized.
Probably Mike's comment on this:
|
This comment has been minimized.
This comment has been minimized.
Given we still don't have any CI running: I want to wait for the actual release, thanks. |
This comment has been minimized.
This comment has been minimized.
Did |
This comment has been minimized.
This comment has been minimized.
Presumably you just need to reinstall the CLT. |
This comment has been minimized.
This comment has been minimized.
Yeah, almost the entire CLT installation got wiped by updating to the GM. A little unexpected. There was no indication that would happen from the upgrade or macOS in general, unless I missed a snippet in the release notes on the developer website. |
This comment has been minimized.
This comment has been minimized.
Hmm. I think it has something to do with the apparently mandatory migration to APFS. Ho hum. |
This comment has been minimized.
This comment has been minimized.
Sounds like a bug in previous installers if they weren't doing that. So is /usr/include back after CLT reinstall? |
This comment has been minimized.
This comment has been minimized.
I deliberately stayed on HFS+ until now, and at least as far as I recall this is the first time I noticed during the CLT installation
Aye. |
This comment has been minimized.
This comment has been minimized.
It's not actually mandatory. There's a |
This comment has been minimized.
This comment has been minimized.
Extremely pushy rather than mandatory then, if you prefer |
This comment has been minimized.
This comment has been minimized.
It's probably more about user confusion than pushiness. Think of how many useless "Should I check that box or not?" inquiries and FUD they've prevented. |
This comment has been minimized.
This comment has been minimized.
Yeah, I get it from that point of view. I have some nerves around using a new filesystem a whole bunch of third-parties haven't even considered the behaviour of yet, but I guess Apple are happy enough with the stability of it to be rolling it out by default without that "Do you want APFS or na?" checkbox displayed as part of the default graphical installation process. Anyway, just wanted to see whether the |
This comment has been minimized.
This comment has been minimized.
I'm curious whether |
This comment has been minimized.
This comment has been minimized.
After the update |
This comment has been minimized.
This comment has been minimized.
This just happened exactly as you described (only thing remaining is the |
MikeMcQuaid
removed
the
do not merge
label
Sep 21, 2017
This comment has been minimized.
This comment has been minimized.
@fxcoudert This can be squashed and merged |
fxcoudert commentedSep 4, 2017
brew tests
with your changes locally?macOS 10.13 is going to be released soon, and we are working on its support. As long as it's considered prerelease, we tell users not to file issues. At this point, I think it's counter-productive and we want to know about potential issues.
Also, the system Ruby on High Sierra is 2.3, so the diagnostics need to be adapted to expect that. However, the Ruby test fails but I'm not sure how to adapt it. Suggestions welcome!