New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_spec.rb: use HTTPS for Git remote test #3122

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@vszakats
Member

vszakats commented Sep 4, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

It seems more realistic to make tests via HTTPS, because this is how Git is used in most cases anyway.

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Sep 4, 2017

Member

Test failure seems unrelated:

Failures:
  1) brew home opens the homepage for a given Formula
     Failure/Error:
       expect { brew "home", "testball", "HOMEBREW_BROWSER" => "echo" }
         .to output("#{Formula["testball"].homepage}\n").to_stdout
         .and not_to_output.to_stderr
         .and be_a_success
       expected block to output "\n" to stdout, but output "https://example.com/testball\n"
     # ./test/cmd/home_spec.rb:12:in `block (2 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/integration_test.rb:44:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:96:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'
Member

vszakats commented Sep 4, 2017

Test failure seems unrelated:

Failures:
  1) brew home opens the homepage for a given Formula
     Failure/Error:
       expect { brew "home", "testball", "HOMEBREW_BROWSER" => "echo" }
         .to output("#{Formula["testball"].homepage}\n").to_stdout
         .and not_to_output.to_stderr
         .and be_a_success
       expected block to output "\n" to stdout, but output "https://example.com/testball\n"
     # ./test/cmd/home_spec.rb:12:in `block (2 levels) in <top (required)>'
     # ./test/support/helper/spec/shared_context/integration_test.rb:44:in `block (2 levels) in <top (required)>'
     # ./test/spec_helper.rb:96:in `block (2 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block (2 levels) in <top (required)>'
@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Sep 6, 2017

Member

Force pushed for another CI run. This time another unrelated failure:

2.00s==> brew audit testbottest --online
Error: 1 problem in 1 formula
testbottest:
  * Incorrect file permissions (664): chmod 644 /home/travis/build/Homebrew/brew/Library/Taps/homebrew/homebrew-core/Formula/testbottest.rb
==> FAILED
brew.bottle.17
Member

vszakats commented Sep 6, 2017

Force pushed for another CI run. This time another unrelated failure:

2.00s==> brew audit testbottest --online
Error: 1 problem in 1 formula
testbottest:
  * Incorrect file permissions (664): chmod 644 /home/travis/build/Homebrew/brew/Library/Taps/homebrew/homebrew-core/Formula/testbottest.rb
==> FAILED
brew.bottle.17
@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Sep 6, 2017

Member

Strange errors :(

Member

vszakats commented Sep 6, 2017

Strange errors :(

@JCount

This comment has been minimized.

Show comment
Hide comment
@JCount

JCount Sep 6, 2017

Member

Yeah, this is a known issue that is currently being worked on in Homebrew/homebrew-test-bot#120, and should hopefully be fixed soon.

Member

JCount commented Sep 6, 2017

Yeah, this is a known issue that is currently being worked on in Homebrew/homebrew-test-bot#120, and should hopefully be fixed soon.

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Sep 7, 2017

Member

Thanks for the fix! The macOS failure was already reported in #3113 and pending a fix.

Member

vszakats commented Sep 7, 2017

Thanks for the fix! The macOS failure was already reported in #3113 and pending a fix.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 8, 2017

Member

Thanks for this @vszakats!

Member

MikeMcQuaid commented Sep 8, 2017

Thanks for this @vszakats!

@MikeMcQuaid MikeMcQuaid merged commit 72251e7 into Homebrew:master Sep 8, 2017

2 of 3 checks passed

codecov/project 50.04% (-1.01%) compared to 5b04152
Details
codecov/patch Coverage not affected when comparing 5b04152...a6d1ddf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vszakats vszakats deleted the vszakats:patch-1 branch Sep 8, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.