New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac/hardware/cpu: recognise Kaby Lake #3125

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Contributor

DomT4 commented Sep 5, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

The 2017 MacBook Pro line shipped with Kaby Lake CPUs. Suspect this is what is causing the dunno in Homebrew/homebrew-core#14418 (comment).

mac/hardware/cpu: recognise Kaby Lake
The 2017 MacBook Pro line shipped with Kaby Lake CPUs.
@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Sep 5, 2017

Contributor

Not really any new testing that can be added here as far as I can see, so 🤷‍♂️.

Contributor

DomT4 commented Sep 5, 2017

Not really any new testing that can be added here as far as I can see, so 🤷‍♂️.

@@ -50,6 +50,8 @@ def family
:broadwell
when 0x37fc219f # Skylake
:skylake
when 0x0f817246 # Kaby Lake
:kabylake

This comment has been minimized.

@ilovezfs

ilovezfs Sep 5, 2017

Contributor

should it be :kaby_lake?

@ilovezfs

ilovezfs Sep 5, 2017

Contributor

should it be :kaby_lake?

This comment has been minimized.

@DomT4

DomT4 Sep 5, 2017

Contributor

IMO, yes. But the Linux side of this code & the CPU Hardware tests are already using this style so I just went with it.

@DomT4

DomT4 Sep 5, 2017

Contributor

IMO, yes. But the Linux side of this code & the CPU Hardware tests are already using this style so I just went with it.

This comment has been minimized.

@ilovezfs

ilovezfs Sep 5, 2017

Contributor

Yuck.

@ilovezfs

ilovezfs Sep 5, 2017

Contributor

Yuck.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 5, 2017

Member

Thanks again @DomT4!

Member

MikeMcQuaid commented Sep 5, 2017

Thanks again @DomT4!

@MikeMcQuaid MikeMcQuaid merged commit c6d5f8c into Homebrew:master Sep 5, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 53.94%)
Details
codecov/project 53.93% (-0.02%) compared to e777010
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DomT4 DomT4 deleted the DomT4:kaby_lake branch Sep 6, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.