New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output when tapping core #3135

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@alyssais
Contributor

alyssais commented Sep 7, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Hiding all output makes it look like Homebrew is hanging while the tap operation (which can take a long time!) is running.

Closes #3053.

Always output when tapping core
Hiding all output makes it look like Homebrew is hanging while the tap
operation (which can take a long time!) is running.

Closes #3053.

@alyssais alyssais requested review from MikeMcQuaid and ilovezfs Sep 7, 2017

@MikeMcQuaid MikeMcQuaid merged commit 4ef0322 into Homebrew:master Sep 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 8, 2017

Member

Nice work @alyssais!

Member

MikeMcQuaid commented Sep 8, 2017

Nice work @alyssais!

@alyssais alyssais deleted the alyssais:core_tap_output branch Sep 8, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.