New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mach: Avoid reopening the file for relocation" #3138

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
1 participant
@ilovezfs
Contributor

ilovezfs commented Sep 8, 2017

Reverts #3101

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs
Contributor

ilovezfs commented Sep 8, 2017

@ilovezfs ilovezfs merged commit 914378c into master Sep 8, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ilovezfs ilovezfs deleted the revert-3101-macho-use-object branch Sep 8, 2017

@ilovezfs ilovezfs referenced this pull request Sep 9, 2017

Closed

gtk+ 3.22.20 update broke libgdk #17861

3 of 5 tasks complete

scpeters added a commit to scpeters/brew that referenced this pull request Sep 27, 2017

keg_relocate: fix call to change_install_name
During the changes to macho file relocation refactoring
in Homebrew#3101, Homebrew#3138, and Homebrew#3139,
the number of arguments to the mach::change_install_name
function changed from 3 to 2, but
there was still an instance of the function being called
with the wrong number of arguments.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.