New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make artifacts singular. #3141

Merged
merged 2 commits into from Sep 11, 2017

Conversation

Projects
None yet
1 participant
@reitermarkus
Member

reitermarkus commented Sep 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Refactor artifacts to use an instance per artifact instead of an instance per artifact group.

@reitermarkus reitermarkus requested a review from vitorgalvao Sep 10, 2017

@reitermarkus reitermarkus merged commit f3ec40d into Homebrew:master Sep 11, 2017

3 checks passed

codecov/patch 84.61% of diff hit (target 50.8%)
Details
codecov/project 67.08% (+16.28%) compared to 5bcce73
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:single-artifacts branch Sep 11, 2017

claui added a commit to claui/brew that referenced this pull request Oct 1, 2017

Unshadow `allow_untrusted` option for pkg artifact
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR Homebrew#3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the method parameters;
in one case, it uses `ignored_install_options` for a parameter name
(instead of the more canonical `_`) for the sake of clarity.

claui added a commit to claui/brew that referenced this pull request Oct 1, 2017

Unshadow `allow_untrusted` option for pkg artifact
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR Homebrew#3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the method parameters;
in one case, it uses `_ignored_install_options` for a parameter name
(instead of the more canonical `_`) for the sake of clarity.

claui added a commit to claui/brew that referenced this pull request Oct 2, 2017

Unshadow `allow_untrusted` option for pkg artifact
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR Homebrew#3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the field to
`stanza_options`; in one case, it uses `_options` for a parameter
name (instead of the more canonical `_`) for the sake of clarity.

claui added a commit to claui/brew that referenced this pull request Oct 2, 2017

Unshadow `allow_untrusted` option for pkg artifact
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR Homebrew#3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the field to
`stanza_options`; in one case, it uses `_options` for a parameter
name (instead of the more canonical `_`) for the sake of clarity.

claui added a commit to claui/homebrew-textmate that referenced this pull request Feb 4, 2018

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.