New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let `curl_download` handle HTTP 416 error. #3142

Merged
merged 1 commit into from Sep 10, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Member

reitermarkus commented Sep 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

curl_download fails when the server returns 416, which was previously only checked implicitly in download strategies using had_incomplete_download.


Fixes Homebrew/homebrew-cask#38331.

@commitay commitay referenced this pull request Sep 10, 2017

Closed

`curl` errors when downloading a Cask file via a URL #38331

4 of 5 tasks complete
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Sep 10, 2017

Member

Nice work here!

Member

MikeMcQuaid commented Sep 10, 2017

Nice work here!

@reitermarkus reitermarkus merged commit 455ec4c into Homebrew:master Sep 10, 2017

1 of 3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reitermarkus reitermarkus deleted the reitermarkus:curl-full-download branch Sep 10, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.