New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #3143

Merged
merged 13 commits into from Sep 10, 2017

Conversation

Projects
None yet
4 participants
@jsoref
Contributor

jsoref commented Sep 10, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@@ -7,7 +7,7 @@ def initialize(*)
end
def run
raise CaskError, "Dump incomplete." if dump_casks == :incomplet
raise CaskError, "Dump incomplete." if dump_casks == :incomplete

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Sep 10, 2017

Member

CC @reitermarkus to check this is correct.

@MikeMcQuaid

MikeMcQuaid Sep 10, 2017

Member

CC @reitermarkus to check this is correct.

This comment has been minimized.

@reitermarkus
@reitermarkus

reitermarkus Sep 10, 2017

Member

Yes.

@MikeMcQuaid

Great catch here, thanks. Pinging @reitermarkus just to check the symbol rename is correct.

@reitermarkus

This comment has been minimized.

Show comment
Hide comment
@reitermarkus

reitermarkus Sep 10, 2017

Member

Nice work here, @jsoref!

Member

reitermarkus commented Sep 10, 2017

Nice work here, @jsoref!

@reitermarkus reitermarkus merged commit 5bcce73 into Homebrew:master Sep 10, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 49.55%)
Details
codecov/project 49.62% (+0.07%) compared to e108cf8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsoref jsoref deleted the jsoref:spelling branch Sep 10, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.